-
Couldn't load subscription status.
- Fork 737
Standard grpc mTLS #3909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Standard grpc mTLS #3909
Changes from 2 commits
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
f1894cf
[platform] added the platform root_cert path utility function.
georgeliao 92ae3eb
[platform] change the default root cert location
georgeliao 47ef48f
[ssl cert] added root certificate generation utility function.
georgeliao a7b70b9
[ssl cert] added the utility function of signing server certificate b…
georgeliao 8838aa3
[ssl cert] a small variable name improvement.
georgeliao 2421fb5
[ssl cert][client] adapted the make_cert_key_pair function so it can …
georgeliao b8310b5
[unit test][ssl cert] fixed the unit tests in test_ssl_cert_provider.cpp
georgeliao 049f7c2
[unit test] fixed the unit tests in test_cli_client.cpp file
georgeliao 3aceacc
[unit test][daemon rpc] fixed the unt tests in test_daemon_rpc.cpp file
georgeliao dd0349e
[unit tests][daemon] fixes the unit tests in test_daemon.cpp
georgeliao 862e62e
[unit test][daemon find] fixed the unit tests in test_daemon_find.cpp
georgeliao 0b5d95f
[unit test][alias dict] fixed the unit tests in test_alias_dict.cpp
georgeliao 065b134
[ssl cert] fixed the format.
georgeliao 7044051
[unit test][client common] fixed the unit tests in test_client_common…
georgeliao dd4e6c1
[unit test] added constness to mock_utils and to corresponding functi…
georgeliao 1ceadc3
[unit test] added constness to MockUtils and corresponding function.
georgeliao 92379b2
[unit test] fixed the format.
georgeliao 54a0093
[ssl cert] added some missed constness.
georgeliao e025373
[unit test] removed daemon_cert and daemon_key.
georgeliao 8ee9d14
[ssl cert] Using OpenSSL's built-in function to create SAN field.
georgeliao ec7cdb2
[ssl cert] use default argument instead of function overload.
georgeliao 33d25a4
[ssl cert] remove the cn_name_from function since the dispatch is don…
georgeliao a017c44
[ssl cert] added cert type enum to facilitate the deduplication of th…
georgeliao 3795eb9
[ssl cert] merged the root, client, signed server certificate generat…
georgeliao 192f690
[ssl cert] modernize the key generation by using openssl 3.0 C apis
georgeliao 905a29c
[ssl cert] use decltype on function pointer directly. So it is consis…
georgeliao a744702
[ssl cert] remove unneeded headers.
georgeliao 61a4282
[ssl cert] use std::array to replace C-style array to interface with …
georgeliao a6e7a84
[ssl cert] added comment on the OSSL_PARAM_construct_utf8_string func…
georgeliao 6f6e66b
[ssl cert] rename x509 to cert for better match with variable name EV…
georgeliao 72f681c
[ssl cert] use nullptr instead of NULL to comply with Modern C++ style.
georgeliao 147b2c2
[ssl cert] using add_extension function to deduplicate some code.
georgeliao d5ee690
[ssl cert] use std::unique_ptr and custom deleter to simplify the code
georgeliao 243efa1
[ssl cert] added check to the pointer and the function return code
georgeliao e94fb2d
[ssl cert] added the root certificate existence check for server cert…
georgeliao 0825a0c
[vcpckg][grpc client] Switch the gRPC repository to the standard one …
georgeliao edf1115
[platform] added snap root cert file path
georgeliao 2b69d63
[ssl cert] fixes the snap version multipass can not overwrite the key…
georgeliao 3058143
[ssl cert] convert from std::function to function pointer to avoid th…
georgeliao 9c5e0a7
[ssl cert] added comment for why use hard coded function pointer
georgeliao 8afa5af
[ssl cert] added a comment for the WritableFile constructor change
georgeliao dc9fdb4
[ssl cert] standardize the serial number format.
georgeliao a3a317e
[ssl cert] using std::unique_ptr to automate memory management.
georgeliao 64aeb8c
[ssl cert] replace fprint with throw.
georgeliao a078ab5
[ssl cert] use raw bitwise operation rather than calling BN_set_bit.
georgeliao 59cb1b3
[unit test][ssl cert] added a comment for creates_different_certs_pe…
georgeliao a8d12f1
[ssl cert] fixes the ci compilation error.
georgeliao 23e3006
[ssl cert] addressed one review comment.
georgeliao 84b1fc1
Update tests/test_alias_dict.cpp
georgeliao ecff7ed
Update tests/test_cli_client.cpp
georgeliao 85f1976
Update tests/test_client_common.cpp
georgeliao c7c7c1f
Update tests/test_daemon_find.cpp
georgeliao c95b81c
Update src/platform/platform_unix.cpp
georgeliao 53fd6c2
[ssl cert] use cached variable to avoid double conversion.
georgeliao 9d83a9e
[platform] fixes the lint.
georgeliao 84d84ef
[platform] move the get_root_cert_path function from unix to linux.
georgeliao b2d0368
Update tests/test_daemon.cpp
georgeliao c321ebc
[platform] fix the lint.
georgeliao 60fe47a
[platform][linux] used the mp::StandardPaths::AppDataLocation instead…
georgeliao ef8bd74
[ssl cert] restore the accidentally deleted X509_set_version call.
georgeliao 82cfa6e
[platform][linux] change the snap case storage location back to snap …
georgeliao 4d374a0
[platform][linux] fix the snap path mistake.
georgeliao 07557b8
[ssl cert] make sure the parent directory of key, certificate file al…
georgeliao 21b6bc9
[ssl cert] fixed the windows build failure.
georgeliao 5f412a2
[ssl cert] replace the remove file with adding owner write permission…
georgeliao 0f97e5c
[client][cert] removed the unneeded check and create directory.
georgeliao e84205a
[ssl cert] move the permission change from WritableFile to EVPKey::wr…
georgeliao 8de2df4
[daemon_config] remove the unneeded MP_UTILS.make_dir call .
georgeliao 9934ea4
[unit test][ssl cert] removed the unneeded MP_UTILS.make_dir call.
georgeliao 5eaf6ad
[unit test][platform linux] added a unit test to cover multipass_fina…
georgeliao 9a353ee
[platform][linux] moved "/data/multipassd" out so the user defined st…
georgeliao c0ce12e
[ssl cert] moved the creating file pointer logic to a function, so th…
georgeliao 6444ca4
[ssl cert] moved the raw key pointer creation into a function so the …
georgeliao 56507be
[ssl cert] used the chrono time units to improve the readability.
georgeliao 1afb812
[ssl cert] added assertion to the end BIGNUM value.
georgeliao 59f1fd5
[ssl cert] changed the remaining NULL to nullptr
georgeliao 302d7d6
[ssl cert] added comment for the usage of the SSLCertProvider class.
georgeliao 9747cbb
[ssl cert] fixed the linter.
georgeliao 3984815
[platform] for just testing snap standardpaths values.
georgeliao d18e3cc
[platform linuxj] removed the logs and use constant variable for mult…
georgeliao c58c8c7
[daemon config] remove the restrict_permissions on data folder.
georgeliao 61f731e
[cert store] enforce ower_all permission to authenticated-certs sub-f…
georgeliao d08a6bb
[qemu platform] enforce ower_all permission to network sub-folder.
georgeliao 90ef620
[open ssh] enforce permission to ssh-keys sub-folder.
georgeliao 3c4d0f4
[vault] enforce ower_all permission to vault sub-folder.
georgeliao 3db5b2e
[daemon] enforce ower_all permission to multipassd-vm-instances.json …
georgeliao eb39c87
[daemon config] added explicit permission setting for overwriting pur…
georgeliao 37858e8
[daemon] use toStdU16String for windows possible non-latin characters.
georgeliao c848554
[ssl cert] enforced zero initialization for some objects creation.
georgeliao 3d22fb5
[ssl cert] added some return code check for some open ssl apis.
georgeliao 2291748
[ssl cert] improve the key creation function by returning unique poin…
georgeliao b34d78e
[ssl cert] changed create_key to be static private function and made …
georgeliao 51c3025
[ssl cert] changing open_file to return unique pointer.
georgeliao a5fbc97
[ssl cert] move the open_file into the WritableFile class.
georgeliao 4b8b386
[ssl cert] added nodiscard attribute to some functions.
georgeliao 19e5257
[utils] added check utility function for checking c-api return.
georgeliao 10f1650
[ssl cert] used the check function checking raw file pointer.
georgeliao 9e69003
[ssl cert] more invocations of the check utility function.
georgeliao bb42414
[ssl cert] more mp::utils::check based refactors
georgeliao 1946644
[ssl cert] more refactor based on mp::utils::check.
georgeliao 9393794
[ssl cert] more refactor based on mp::utils::check.
georgeliao 56c478f
[ssl cert] refined the check utility function.
georgeliao c3f3bc9
[ssl cert] more refactor based mp::utils::check function.
georgeliao 7a5118a
[ssl cert] more refactor based on the mp::utils::check function.
georgeliao af78689
[ssl cert] confined the check utility function into ssl_cert_provider…
georgeliao 897c924
Update src/daemon/daemon_config.cpp
georgeliao ccac46a
[file permission] use restrictive default permission, and only open u…
georgeliao d5d8ac6
Revert "[cert store] enforce ower_all permission to authenticated-cer…
georgeliao a8366de
[daemon config] used two steps approach for permission setting.
georgeliao aed8425
[snap] make snap to setup necessary directory for multipass
georgeliao 7254f69
[daemon config][ssl cert] added group user needed permission for acce…
georgeliao 268ac0d
[ssl cert] fixed the server restart causes the root certificate lose …
georgeliao fb49148
[ssl cert] added comment for the existing root cert permission overwr…
georgeliao 6c97765
Update src/cert/ssl_cert_provider.cpp
georgeliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.