Skip to content

Conversation

@georgeliao
Copy link
Contributor

@georgeliao georgeliao commented Jan 13, 2025

Updated the vcpkg from 2023.10.19~628 to 2024.02.14. This small update does not leap vcpkg to the latest version which is 2024.12.16, but it can fix the windows build without breaking the old grpc build.

@georgeliao georgeliao marked this pull request as draft January 13, 2025 09:18
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (fc3249c) to head (966382a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3872   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files         255      255           
  Lines       14577    14577           
=======================================
  Hits        12977    12977           
  Misses       1600     1600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgeliao georgeliao marked this pull request as ready for review January 13, 2025 13:01
@georgeliao georgeliao requested review from Sploder12 and ricab January 13, 2025 13:37
@@ -1,5 +1,5 @@
{
"builtin-baseline": "ca7b1b15f548c25c766360593a2c732d56ed0133",
"builtin-baseline": "fba75d09065fcc76a25dcf386b1d00d33f5175af",
Copy link
Contributor Author

@georgeliao georgeliao Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit hash of vcpkg of the tag 2024.02.14.

Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hashes match and some manual testing revealed no issues. Nice job!

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@ricab ricab added this pull request to the merge queue Jan 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@ricab ricab added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 13, 2025
@georgeliao georgeliao added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 78bdb6d Jan 14, 2025
22 checks passed
@georgeliao georgeliao deleted the update_vcpkg branch January 14, 2025 13:40
ricab pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants