-
Notifications
You must be signed in to change notification settings - Fork 737
updated vcpkg to 2024.02.14 #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3872 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 255 255
Lines 14577 14577
=======================================
Hits 12977 12977
Misses 1600 1600 ☔ View full report in Codecov by Sentry. |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "builtin-baseline": "ca7b1b15f548c25c766360593a2c732d56ed0133", | |||
| "builtin-baseline": "fba75d09065fcc76a25dcf386b1d00d33f5175af", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the commit hash of vcpkg of the tag 2024.02.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Hashes match and some manual testing revealed no issues. Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks!
updated vcpkg to 2024.02.14
Updated the vcpkg from 2023.10.19~628 to 2024.02.14. This small update does not leap vcpkg to the latest version which is 2024.12.16, but it can fix the windows build without breaking the old grpc build.