Skip to content

Conversation

@krisstern
Copy link

@krisstern krisstern commented Jan 25, 2022

Fixes #1461.

This PR intends to enable cloud-init using a URL using a YAML file.

TODOs:

@krisstern
Copy link
Author

Hi @Saviq I am thinking about where to add some test(s) for this PR. Any suggestions?

@Saviq
Copy link
Collaborator

Saviq commented Jan 28, 2022

Hey, probably best if you base it off of #2348 where @townsend2010 started splitting the cli tests up.

@krisstern
Copy link
Author

Yup, sure. Let me checkout that PR #2348 and rebase mine against a bumped version of it... But I will wait a bit to see if the contributor of that PR will bump first, before resorting to this option.

@Saviq
Copy link
Collaborator

Saviq commented Feb 16, 2022

Hi @krisstern, will you be able to work on this?

@krisstern
Copy link
Author

Hi @Saviq Are we still waiting for progress to be made at #2348?

@Saviq
Copy link
Collaborator

Saviq commented Feb 16, 2022

Hi @Saviq Are we still waiting for progress to be made at #2348?

Just ignore that one for now - as Chris reported, there's a piece of refactoring that would need to happen there and the whole purpose of that PR was to just split things up. That shouldn't block you, please just start from main.

@krisstern
Copy link
Author

krisstern commented Feb 16, 2022

Okay, let me restart work on this PR this weekend

@krisstern
Copy link
Author

Sorry, as I no longer have access to Ubuntu I cannot work on this issue further.

@krisstern krisstern closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cloud-init url

2 participants