Skip to content

Conversation

@DeeKay3
Copy link
Contributor

@DeeKay3 DeeKay3 commented Jul 10, 2025

Applicable ticket: ISD-3479

Overview

Proposed documentation changes are to fix vale errors.

Rationale

Vale is giving out errors and we are trying to make every documentation compliant with it.

Juju Events Changes

Module Changes

Library Changes

Checklist

@DeeKay3 DeeKay3 requested a review from a team as a code owner July 10, 2025 14:23
@DeeKay3 DeeKay3 added the documentation Improvements or additions to documentation label Jul 10, 2025
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@DeeKay3 DeeKay3 enabled auto-merge (squash) July 11, 2025 14:57
@DeeKay3 DeeKay3 disabled auto-merge July 11, 2025 14:57
@github-actions
Copy link
Contributor

Test results for commit 659cd39

Test coverage for 659cd39

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/agent.py         60      0     12      0   100%
src/charm.py         57      0     10      0   100%
src/metadata.py       8      0      0      0   100%
src/pebble.py        23      0      0      0   100%
src/server.py        50      0     12      0   100%
src/state.py         66      1     10      1    97%   99
-------------------------------------------------------------
TOTAL               264      1     44      1    99%

Static code analysis report

Run started:2025-07-11 15:01:09.029109

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1667
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@srbouffard srbouffard merged commit 55f6c71 into main Jul 14, 2025
21 of 25 checks passed
@srbouffard srbouffard deleted the docs/ISD-3479/vale-fixes branch July 14, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants