Skip to content

Conversation

@yanksyoon
Copy link
Member

Applicable spec:

Overview

  • Add charm architecture diagram

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@yanksyoon yanksyoon added the documentation Improvements or additions to documentation label Mar 11, 2025
@yanksyoon yanksyoon requested a review from a team as a code owner March 11, 2025 06:02
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the architecture diagram! I'll make a couple of changes to some of the text that you didn't touch in Juju events and Charm code overview.

@yanksyoon yanksyoon requested a review from erinecon March 12, 2025 02:46
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick from me :) let me know if you have any concerns about the commit I made to the ### Jenkins agent K8s section!

yanksyoon and others added 3 commits March 12, 2025 20:05
Co-authored-by: Erin Conley <erin.conley@canonical.com>
This reverts commit 6670c3c.
@github-actions
Copy link
Contributor

Test results for commit 18eaafa

Test coverage for 18eaafa

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/agent.py         60      0     12      0   100%
src/charm.py         57      0     10      0   100%
src/metadata.py       8      0      0      0   100%
src/pebble.py        23      0      0      0   100%
src/server.py        50      0     12      0   100%
src/state.py         66      0     10      0   100%
-------------------------------------------------------------
TOTAL               264      0     44      0   100%

Static code analysis report

Run started:2025-03-13 04:18:25.917753

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1667
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yanksyoon yanksyoon merged commit efd1309 into main Mar 13, 2025
17 checks passed
@yanksyoon yanksyoon deleted the docs/charm-architecture-diagram branch March 13, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants