Skip to content

Conversation

@cbartz
Copy link
Contributor

@cbartz cbartz commented Apr 28, 2025

While reviewing PRs, I tend to comment on TODO comments.

I created this PR to see if we can reach an agreement or start a discussion about the topic.

@cbartz cbartz requested a review from a team as a code owner April 28, 2025 09:39
@cbartz cbartz requested review from amandahla and srbouffard and removed request for amandahla and srbouffard April 28, 2025 09:39
@nrobinaubertin
Copy link
Contributor

In general I would agree but TODOs in code exist because they are frictionless. I fear that enforcing that would just mean that TODOs wouldn't be written anymore (without any jira ticket).

Copy link

@varshigupta12 varshigupta12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general TODOs should be resolved before merging the code and if there are any long standing pending items, JIRA tickets should be created instead.

@cbartz
Copy link
Contributor Author

cbartz commented Apr 28, 2025

In general I would agree but TODOs in code exist because they are frictionless. I fear that enforcing that would just mean that TODOs wouldn't be written anymore (without any jira ticket).

I think exceptions to the contribution guidelines can always be made for certain cases if they are well explained, but the goal should be to avoid merging code with TODO comments to the default branch. Although TODO comments are frictionless, they reduce readability later on. It's still fine to have TODO comments on a feature PR before merging.

@cbartz cbartz merged commit 1fb4d64 into main May 5, 2025
1 check passed
@cbartz cbartz deleted the todos-in-code branch May 5, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants