Skip to content

Conversation

@samhotep
Copy link
Member

@samhotep samhotep commented Dec 5, 2024

Done

  • Added an explicit login page to comply with login.ubuntu.com SSO configuration.

Logging in with SSO is inconsistent on staging and production due to CORS headers being modified or stripped by the content-cache during the redirect to login.ubuntu.com. With this page, the redirect is triggered by the user hence avoiding needing CORS.

QA

  • Open the demo. If not logged in, you should be directed to /login_page. Clicking the log in button should trigger the sso flow, and redirect you to the dashboard.
  • Logging out should redirect you to /login_page

@webteam-app
Copy link

@petesfrench
Copy link

  • I logged in and was redirected to the landing page
  • I clicked the log out button and was redirected to the login page (all good so far)
  • I then removed /login_page from the URl and loaded the page and it went to the landing page

Expected behaviour:

  • to be redirected to the login page, as I should be logged out

@samhotep
Copy link
Member Author

samhotep commented Dec 5, 2024

Great catch! It seems to be a stale browser session @petesfrench, lemme see if there's a quick way we can clear it from within the app

Copy link

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samhotep samhotep merged commit ab0e549 into main Dec 5, 2024
7 checks passed
@samhotep samhotep deleted the add-sso-login-page branch December 5, 2024 16:42
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants