Fix crash when google creds are unavailable #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
samhotep
force-pushed
the
fix-google-creds-crash
branch
from
08fd68d to
473375b
Compare
|
@samhotep from looking at the demo two things that are immediately visible:
|
akbarkz
force-pushed
the
fix-google-creds-crash
branch
from
fc049df to
97c3ba6
Compare
akbarkz
added
Review: Code +1
Review: QA +1
and removed
Review: Code Needed
Review: QA -1
labels
|
There is still an issue with new webpages not being created. There is an error coming from Google Drive, but that will be fixed separately. |
akbarkz
approved these changes
Dec 3, 2024
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA steps
Fixes
WD-16241