Skip to content

do not show a chip for null in owner and reviewers #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

do not show a chip for null in owner and reviewers #56

merged 1 commit into from
Sep 12, 2024

Conversation

@akbarkz
Copy link
Contributor

@akbarkz akbarkz commented Sep 11, 2024 •
edited
Loading

Done

  • In case a value is null do not show a chip in "Owner" field

QA

  • Locally this does not reproduce, since there is always a value for "Owner" field. By default there is always "Default" user. On production there is no "Default" user, so an empty object will be returned if no owner is defined. So no QA is needed, only code review.

Screenshots

Currently on prod:
Screenshot 2024-09-11 at 19 14 16

Should be:
Screenshot 2024-09-11 at 19 14 52

@akbarkz akbarkz merged commit 59bab7e into main Sep 12, 2024
7 checks passed
@akbarkz akbarkz deleted the task/WD-13340-set_owner_ui branch September 12, 2024 03:59
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pastelcyborg pastelcyborg pastelcyborg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Review: Code +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akbarkz @pastelcyborg