Add settings to handle HTTPS requests #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guillaumebeuzeboc
approved these changes
Aug 27, 2025
giusebar
changed the title
giusebar
changed the title
Guillaumebeuzeboc
approved these changes
Aug 28, 2025
artivis
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📝
This PR adds some Django settings to handle TLS. The changes include:
Dynamic CSRF Trusted Origins:
Introduced CSRF_TRUSTED_ORIGINS in settings.py using an environment variable. This ensures that Django admin POST requests work correctly over HTTPS.
Secure Proxy Header:
Added SECURE_PROXY_SSL_HEADER = ("HTTP_X_FORWARDED_PROTO", "https") to trust the proxy header for detecting if the original request was made over HTTPS.
Foxglove WebSocket Security:
Configured Foxglove WebSocket to use secure connections if the request is HTTPS.
This PR also adds a test to verify that HTTPS links associated to a device are handled correctly.
Checks