chore: fix unsafe access to result[1].msgs
#417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wendong-Fan
reviewed
Apr 3, 2025
| if len(result) >= 2 and hasattr(result[1], 'msgs') and result[1].msgs and len(result[1].msgs) > 0: | ||
| if len(result) >= 2 and hasattr(result[1], 'msgs') and result[1].msgs: |
There was a problem hiding this comment.
thanks @zkpepe for the PR, I don't understand why we remove len(result[1].msgs) > 0 check here and how could it improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue in
run_society_with_strict_limitwhereresult[1].msgscould cause errors if the structure wasn't as expected. Now the checks are more robust, ensuring safe access tomsgs.