Skip to content

value change does not change StepMarker position #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

150 changes: 150 additions & 0 deletions package/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"@react-native/eslint-config": "0.76.3",
"@react-native/metro-config": "0.76.3",
"@react-native/typescript-config": "0.76.3",
"@testing-library/react-native": "^13.2.0",
"@types/jest": "^28.1.8",
"@types/react": "^18.2.6",
"@types/react-test-renderer": "^18.0.0",
Expand Down
4 changes: 4 additions & 0 deletions package/src/Slider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ const SliderComponent = (

const passedValue = Number.isNaN(value) || !value ? undefined : value;

useEffect(() => {
setCurrentValue(value);
}, [value]);

useEffect(() => {
if (lowerLimit >= upperLimit) {
console.warn(
Expand Down
135 changes: 79 additions & 56 deletions package/src/__tests__/Slider.test.tsx
Original file line number Diff line number Diff line change
@@ -1,89 +1,112 @@
import {render, screen} from '@testing-library/react-native';
import * as React from 'react';
import renderer from 'react-test-renderer';
import {MarkerProps} from '../../typings';
import Slider from '../Slider';
import {View} from 'react-native';
import {Text, View} from 'react-native';

describe('<Slider />', () => {
it('renders enabled slider', () => {
const tree = renderer.create(<Slider />).toJSON();
render(<Slider />);

expect(tree).toMatchSnapshot();
expect(screen).toMatchSnapshot();
});

it('renders disabled slider', () => {
const tree = renderer.create(<Slider disabled />).toJSON();
render(<Slider disabled />);

expect(tree).toMatchSnapshot();
expect(screen).toMatchSnapshot();
});

it('accessibilityState disabled sets disabled={true}', () => {
const tree = renderer
.create(<Slider accessibilityState={{disabled: true}} />)
.toJSON();
render(<Slider accessibilityState={{disabled: true}} />);

expect(tree).toMatchSnapshot();
expect(screen).toMatchSnapshot();
});

it('disabled prop overrides accessibilityState.disabled', () => {
const tree = renderer
.create(<Slider disabled accessibilityState={{disabled: false}} />)
.toJSON();
render(<Slider disabled accessibilityState={{disabled: false}} />);

expect(tree).toMatchSnapshot();
expect(screen).toMatchSnapshot();
});

it('disabled prop overrides accessibilityState.enabled', () => {
const tree = renderer
.create(<Slider disabled={false} accessibilityState={{disabled: true}} />)
.toJSON();
render(<Slider disabled={false} accessibilityState={{disabled: true}} />);

expect(tree).toMatchSnapshot();
expect(screen).toMatchSnapshot();
});

it('renders a slider with custom props', () => {
const tree = renderer
.create(
<Slider
value={0.5}
minimumValue={-1}
maximumValue={2}
step={0.25}
minimumTrackTintColor={'blue'}
maximumTrackTintColor={'red'}
thumbTintColor={'green'}
onSlidingComplete={() => {}}
onValueChange={() => {}}
lowerLimit={0}
upperLimit={1}
/>,
)
.toJSON();

expect(tree).toMatchSnapshot();
render(
<Slider
value={0.5}
minimumValue={-1}
maximumValue={2}
step={0.25}
minimumTrackTintColor={'blue'}
maximumTrackTintColor={'red'}
thumbTintColor={'green'}
onSlidingComplete={() => {}}
onValueChange={() => {}}
lowerLimit={0}
upperLimit={1}
/>,
);

expect(screen).toMatchSnapshot();
});

it('renders a slider with custom stepMaker', () => {
const tree = renderer
.create(
render(
<Slider
value={2}
minimumValue={0}
maximumValue={4}
StepMarker={({stepMarked}) => {
return stepMarked ? (
<View>
<View style={{width: 10, backgroundColor: 'red'}} />
</View>
) : (
<View>
<View style={{width: 10, backgroundColor: 'green'}} />
</View>
);
}}
/>,
);

expect(screen).toMatchSnapshot();
});

it('Set custom thumbImage and stepMarker when value is changed', () => {
const {rerender} = render(<TestSlider value={2} />);
expect(screen.getByTestId('marked')).toHaveTextContent('C:2 I:2');

rerender(<TestSlider value={0} />);
expect(screen.getByTestId('marked')).toHaveTextContent('C:0 I:0');

expect(screen).toMatchSnapshot();

function TestSlider({value}: {value: number}) {
return (
<Slider
value={2}
value={value}
minimumValue={0}
maximumValue={4}
StepMarker={({stepMarked}) => {
return stepMarked ? (
<View>
<View style={{width: 10, backgroundColor: 'red'}} />
</View>
) : (
<View>
<View style={{width: 10, backgroundColor: 'green'}} />
</View>
);
}}
/>,
)
.toJSON();

expect(tree).toMatchSnapshot();
StepMarker={TestStepMarker}
/>
);
}

function TestStepMarker({index, currentValue, stepMarked}: MarkerProps) {
return (
<View>
<Text
testID={
stepMarked ? 'marked' : `marker_${index}`
}>{`C:${currentValue} I:${index}`}</Text>
</View>
);
}
});
});
Loading
Loading