Skip to content

Push a newer image with a more updated node version #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

vevetron
Copy link
Contributor

Description

The jupyter images are having serious issues with the node version in the current jupyter notebook.

This switched to a newer image on the same version of python. It also uses something like node ~22, while the old used node ~20.

Resolves #(cal-itp/data-analyses#1388)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Can't test locally, but the build.log looks good!

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)
    Test in prod

Copy link

github-actions bot commented Feb 26, 2025

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

jupyterhub, continuous-image-puller, DaemonSet (apps) has changed:
...
            securityContext:
              allowPrivilegeEscalation: false
              runAsGroup: 65534
              runAsUser: 65534
          - name: image-pull-singleuser
-           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2025.2.20
+           image: ghcr.io/cal-itp/data-infra/jupyter-singleuser:2025.2.26
            command:
              - /bin/sh
              - -c
              - echo "Pulling complete"
            securityContext:
...
jupyterhub, hub, ConfigMap (v1) has changed:
...
          configuration item if not None
          """
          data = get_config(key)
          if data is not None:
              setattr(cparent, name, data)
-   checksum_hook-image-puller: "c98912b04c4a7e36d593d84da801201975ee0e56a32729d076e5376e86c27bed"
+   checksum_hook-image-puller: "26c29bfde1bb195c7b342fce668cc51d81952ff7613f9b68d80e6b09418158c1"
jupyterhub, hub, Deployment (apps) has changed:
...
          release: jupyterhub
          hub.jupyter.org/network-access-proxy-api: "true"
          hub.jupyter.org/network-access-proxy-http: "true"
          hub.jupyter.org/network-access-singleuser: "true"
        annotations:
-         checksum/config-map: be38254088b95749721c745cc3f987a3ce07d3c128c6f1f23b42d5218a4ee1d0
-         checksum/secret: cc3d747c05f5f19fc23b99d1c36b0e021b65adedc749f507e3750ca5b49761c5
+         checksum/config-map: eb0762f69fba99ebd9243f8e71e21d032e8b159503e9ee548a2b61064c799570
+         checksum/secret: 53d8c5195af2988787dcc36dbba731c790b108633abdb17e871a0d7fec9649d1
      spec:
        tolerations:
          - effect: NoSchedule
            key: hub.jupyter.org/dedicated
            operator: Equal
...
jupyterhub, hub, Secret (v1) has changed:
...
    name: hub
  data:
    hub.config.ConfigurableHTTPProxy.auth_token: 'REDACTED # (64 bytes)'
    hub.config.CryptKeeper.keys: 'REDACTED # (64 bytes)'
    hub.config.JupyterHub.cookie_secret: 'REDACTED # (64 bytes)'
-   values.yaml: '-------- # (12166 bytes)'
+   values.yaml: '++++++++ # (12166 bytes)'
  type: Opaque

@vevetron vevetron force-pushed the update_node_in_jupyter_without_revert branch from ce2089d to 51c2b09 Compare February 26, 2025 19:23
@vevetron
Copy link
Contributor Author

build.log

@vevetron vevetron force-pushed the update_node_in_jupyter_without_revert branch from 51c2b09 to 9113eac Compare February 26, 2025 19:27
@vevetron vevetron force-pushed the update_node_in_jupyter_without_revert branch from 9113eac to d055f73 Compare February 26, 2025 19:30
@vevetron vevetron marked this pull request as ready for review February 26, 2025 19:44
@vevetron vevetron requested a review from evansiroky as a code owner February 26, 2025 19:44
@edasmalchi edasmalchi self-requested a review February 26, 2025 19:48
Copy link
Member

@edasmalchi edasmalchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fingers crossed!

@vevetron vevetron merged commit 10bb076 into main Feb 26, 2025
3 checks passed
@vevetron vevetron deleted the update_node_in_jupyter_without_revert branch February 26, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants