docker refactor #671
Open
docker refactor #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete duplicate files - merge latex to main container - requirements: skip bcrypt version - refactor quickSetup.py for entrypoint.py - entrypoint.py - refactor Dockerfile - compose.yml - docs
tools complained about missing dependencies
|
Thanks for the pull request, and sorry for the slow response. The machine I usually use for CAIRIS dev/testing is out of action at the moment, but it could be a while until I get around to checking/integrating this. I'll do this as soon as I can though. |
/cairis/images is already present in the build, it doesn't seem like it gets changed at all - no use in exposing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to deploy with Docker, yet the setup wasn't great. Refactored it a bit.