-
Notifications
You must be signed in to change notification settings - Fork 1.5k
cranelift: stack-switching support #11003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
posborne
wants to merge
29
commits into
bytecodealliance:main
Choose a base branch
from
posborne:stack-switching-cranelift
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,441
−92
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
2ab6356
cranelift: stack-switching support
frank-emrich 0853a16
cranelift: stack-switching updates pass 1
posborne 858b22a
cranelift: stack-switching: restore original visibility for a few fun…
posborne 43a3972
cranelift: stack-switching conditional compilation
posborne 100d621
cranelift: avoid "as" casts in stack-switching
posborne 00c2b56
cranelift: cleanup stack-switching control_effect signatures
posborne e9fa92d
cranelift: rename stack-switching VMArray to VMHostArray
posborne 866fbff
stack-switching: fix typo
posborne 115e503
stack-switching: used Index impl for get_stack_slot_data
posborne 11c6b4a
stack-switching: use smallvec over vec in several cases
posborne fa8001e
stack-switching: avoid resumetable naming confusion
posborne 51017f2
stack-switching: cleanup unused params from unchecked_get_continuation
posborne 44c2b34
stack_switching: simplify store_data_entries assertion
posborne b8fb8b3
stack-switching: simplify translate_table_{grow,fill} control flow
posborne a693350
stack-switching: remove translate_resume_throw stub
posborne eeab1b1
stack-switching: compute control_context_size based on target triple
posborne 3bd138f
stack-switching: VMHostArrayRef updates
posborne 49313bc
stack-switching: move cranelift code to live under func_environ
posborne 5ccd3f7
Merge remote-tracking branch 'upstream/main' into stack-switching-cra…
posborne c86b06a
stack-switching: formatting fix
posborne ab50f6c
stack-switching: reduce visibility on a few additional items
posborne 6797ea2
stack-switching: simplify contobj fatptr con/de-struction
posborne a6a3ff8
stack-switching: add disas tests to cover new instructions
posborne 71c1e6d
Merge remote-tracking branch 'upstream/main' into stack-switching-cra…
posborne ba013f9
stack-switching: fix layout of VMContObj
posborne 3a26125
Merge remote-tracking branch 'upstream/main' into stack-switching-cra…
posborne 8d06297
Fix formatting of merge conflict resolution
posborne cae4878
cranelift: remove ir::function::get_stack_slot_data
posborne 2bdfb25
Merge remote-tracking branch 'upstream/main' into stack-switching-cra…
posborne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? Wasm doesn't have 128bit integers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in this iteration of the changes, the stack switching code is using an i128 for it's vmcontobj fat pointer (consisting of vmcontref pointer and revision). @fitzgen and I have discussed a bit about how we can get rid of this and just have two ir values through the transformation, but it will require some additional changes to how we model the relationship between wasm and clif values to support having one of the former map to two distinct ir values.