Fix test bless #1948
Closed
Fix test bless #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Dec 10, 2024
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
Mind adding a special case that skips the output if the output is empty? (avoids adding lots of empty files)
|
I think this ended up happening in #1954, so I'm going to close this |
|
oops, sorry I forgot I had this open. Ty for closing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1946 I noticed that the test case bless flag was changing a lot of files (174). That's because we currently include a mix of files where some have trailing newlines and others do not. This fixes the test case bless flag to always include trailing newlines - and then blesses the test suite to ensure all files have a trailing newline.
This should make it a lot easier to bless subsequent runs. Thanks!