Skip to content

Conversation

Sieluna
Copy link
Contributor

@Sieluna Sieluna commented Jan 23, 2025

I find this feature quite useful. If you have time, could you help check if there are any security issues?

  • Port simple sample from c
  • Make full type integration test

@Sieluna
Copy link
Contributor Author

Sieluna commented Jan 24, 2025

image

🎉

//! }
//! ```
//!
#![doc = include_str!("../README.md")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one

@lum1n0us
Copy link
Collaborator

lum1n0us commented Feb 3, 2025

Thank you for your contribution. It would be better to consider and include a wider variety of Rust types.

A string in Rust is different from a C-style string. Given that WAMR is a C-based engine, a Rust string cannot be handled well without transformation.

We might also need to consider ownership for the values of certain types. We should aim to prevent users from worrying about this aspect.

wit-bindgen might provide some insights into type translation. After all, all the types we are dealing with here will first be converted into WebAssembly types, rather than directly into C types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants