Do not define statx_flags for LoongArch64 with musl
#1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`libc` already defines constants like `STATX_TYPE` for `musl 1.2.3+` [^1], so `statx_flags` is unnecessary in this environment. [^1]: https://docs.rs/libc/latest/src/libc/unix/linux_like/mod.rs.html#1679 Fixes #1502
heiher
force-pushed
the
no-statx-flags-musl
branch
from
9d874d2 to
d7c1172
Compare
heiher
changed the title
statx_flags for target_env = "musl"statx_flags for LoongArch64 with musl
|
Thanks! |
|
Thanks! Could you tag a new release with this? The issue is blocking downstream packaging of ty. |
|
This is now released in rustix 1.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcalready defines constants likeSTATX_TYPEformusl 1.2.3+1, sostatx_flagsis unnecessary in this environment.Fixes #1502
Footnotes
https://docs.rs/libc/latest/src/libc/unix/linux_like/mod.rs.html#1679 ↩