Backport patches to 1.0 #1492
Merged
Backport patches to 1.0 #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests appear to be failing on FreeBSD 15 due to a difference in behavior on `SOCK_SEQPACKET` FreeBSD 15. They pass on FreeBSD 14 and on other OS's.
* Expand the windows-sys dependency to include 0.60.0. Expand the windows-sys dependency to ">=0.52, <0.61", to support the new windows-sys 0.60. windows-sys 0.60 does make one change that affected rustix, which is to move the `BOOL` type from `windows_sys::Win32::Foundation::BOOL` to `windows_sys::core::BOOL`, so to support both old and new versions, just hard-code the `BOOL` type, as it's just an `i32` and always will be. * Pin more packages for the MSRV build. * Fix warnings. * Disable more test on FreeBSD.
This works around the issue filed upstream in rust-lang/rust#143164.
* Use new `hints.mostly-unused` Most users of the `rustix` crate will use a fraction of its API surface area. Nightly rustc provides an option `-Zhint-mostly-unused` to tell it to defer as much compilation as possible, which provides a substantial performance improvement if most of that compilation doesn't end up happening. Cargo plumbs this option through using the new `[hints]` table. This will cause users of the `rustix` crate to default to setting `hint-mostly-unused`. (Top-level crates can override this if they wish, using a new profile option.) Note that setting this hint does not increase the MSRV of the rustix crate, as old versions of Cargo will ignore it. New versions of Cargo will respect it automatically (and, until we stabilize it, Cargo will do nothing unless you pass `-Zprofile-hint-mostly-unused` to cargo). Some sample performance numbers: this takes `rustix` compilation time with `all-apis` enabled from 5.9s to 4.3s (a 27% improvement). * Add comment to the mostly-unused hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches introducing new features will be released in rustix 1.1. This PR is a backport of patches for 1.0.