-
Notifications
You must be signed in to change notification settings - Fork 16
WIP: Support wasip2 in Go 1.24 #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
27bb9ef
515bb80
d4970f2
b0c1cb8
4604c9a
b8d70f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module go.bytecodealliance.org/cm | ||
|
||
go 1.23.0 | ||
go 1.24.0 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ func Some[T any](v T) Option[T] { | |
// followed by storage for the associated type T. | ||
type option[T any] struct { | ||
_ HostLayout | ||
isSome uint8 | ||
isSome uint32 | ||
some T | ||
} | ||
|
||
|
@@ -47,6 +47,10 @@ func (o *option[T]) Some() *T { | |
return nil | ||
} | ||
|
||
func (o option[T]) IsSome() bool { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This grows the public API of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Entirely okay to revert. |
||
return o.isSome == 1 | ||
} | ||
|
||
// Value returns T if o represents the some case, | ||
// or the zero value of T if o represents the none case. | ||
// This does not have a pointer receiver, so it can be chained. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module go.bytecodealliance.org | ||
|
||
go 1.23.0 | ||
go 1.24.0 | ||
|
||
require ( | ||
github.com/coreos/go-semver v0.3.1 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
go 1.23.0 | ||
go 1.24.0 | ||
|
||
use ( | ||
. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// This go.mod file exists to prevent the testdata directory from being included in module distribution. | ||
module testdata | ||
|
||
go 1.23.0 | ||
go 1.24.0 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
This will break ABI compatibility on TinyGo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically the uint8 isn't correct WRT the CM's canonical ABI, hence the change. Can you say how this breaks things on TinyGo? I'd assume that new code using newly generated bindings would continue to work as before?
(To be clear, I think it's fine to revert this, since the relevant bit will always reside in the same byte, whether the rest is filled with padding or is represented by the
uint32
.)