Skip to content

fix: remove log during cabi_realloc #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

fix: remove log during cabi_realloc #273

merged 1 commit into from
Jul 22, 2025

Conversation

vados-cosmonic
Copy link
Contributor

No description provided.

@vados-cosmonic vados-cosmonic marked this pull request as ready for review July 22, 2025 10:24
tschneidereit
tschneidereit approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I'm baffled by how this ever worked at all

@vados-cosmonic
Copy link
Contributor Author

Same, so baffled I asked about it#wasmtime > ✔ violating component may_leave during cabi_realloc 😅

@vados-cosmonic vados-cosmonic merged commit 86b1f90 into bytecodealliance:main Jul 22, 2025
16 checks passed
@vados-cosmonic vados-cosmonic deleted the fix=remove-log-during-realloc branch July 22, 2025 23:12
@vados-cosmonic vados-cosmonic mentioned this pull request Jul 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschneidereit tschneidereit tschneidereit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vados-cosmonic @tschneidereit