Skip to content

Conversation

@mtichavsky
Copy link
Contributor

The issue occurred because of changes in version 10 of pnpm, which broke
better-sqlite3 installation. More details here:
WiseLibs/better-sqlite3#1378 (comment)

The issue occurred because of changes in version 10 of pnpm, which broke
better-sqlite3 installation. More details here:
WiseLibs/better-sqlite3#1378 (comment)
@mtichavsky mtichavsky requested a review from tianzhou as a code owner June 26, 2025 09:30
Copy link
Contributor

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's give it a shot

@mtichavsky
Copy link
Contributor Author

Tested by building the container with podman bulid, and checking that execute_sql endpoint works.

@tianzhou tianzhou merged commit 2169b26 into bytebase:main Jun 26, 2025
1 check failed
tianzhou added a commit that referenced this pull request Jun 26, 2025
Bring SQLite back thanks to #71
@mtichavsky mtichavsky deleted the sqlite-fix branch June 26, 2025 10:06
@tianzhou
Copy link
Contributor

I have verified the fix and bumped the package to 0.10.0. Thanks!

@tianzhou tianzhou mentioned this pull request Jun 26, 2025
@mtichavsky
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants