Add Expo tests #618
Add Expo tests #618
Conversation
It doesn't work on Expo and isn't really used much anyway
Browser bundle sizeNPM build
CDN build
Code coverageCoverage values did not change👌. Total:
Generated against c815325 on 30 April 2025 at 11:45:54 UTC |
|
|
||
| export default function HomeScreen() { | ||
|
|
||
| const [currentScenario, setCurrentScenario] = useState<any>(null) |
There was a problem hiding this comment.
could we set just the scenario name here and select the component dynamically? I think this is probably quite a lot of information to store in state
There was a problem hiding this comment.
that's true - we certainly could, I just decided not to because it makes the withInstrumentedAppStarts scenario a more awkward to deal with - that component needs to be wrapped so we'd need to do that in each of the index.js files instead.
As it's just a test app and we only set that state once when we start the scenario I don't think it matters too much?
There was a problem hiding this comment.
could it work with something like:
import scenarios from '../scenario-launcher/scenarios'
const [currentScenario, setCurrentScenario] = useState('ExpoScenario')
currentScenario && <scenarios[currentScenario].Component />
Goal
Add Expo builds and tests to CI pipeline.
Design
Test fixtures are generated dynamically and tests run (more or less) the same test suite as React Native, against the latest 3 Expo versions (currently 52, 51 and 50).
Had to remove the
react-native-dotenvdependency from the scenario launcher as this doesn't work on Expo - this was just a convenience tool for running scenarios locally but isn't really necessary.Testing
Covered by CI