Add bufcheck support for remote policies #3934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to bufcheck.Clients to invoke remote Policies with remote Plugins. Remote Policies are pulled from a registry and stored locally in the buf cache. Remote plugins are supported for both Local and Remote Policies. These are resolved through the policy's plugin providers (see the buf.lock file changes).
Invoking a remote policy will show the PolicyRef, and the PluginRef if a custom plugin, per each lint annotation. For example with a remote policy that enforces a custom plugin:
Policies that invoke just a built-in rule do not have a plugin reference
(buf.build/acme/buf-policy-suffix:v1)