Add audit log for policy enforcements #3912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
unmultimedio
reviewed
Jul 7, 2025
| EVENT_TYPE_POLICY_ENFORCEMENT_CREATED = 74; | ||
| EVENT_TYPE_POLICY_ENFORCEMENT_DELETED = 75; | ||
| EVENT_TYPE_POLICY_ENFORCEMENT_POLICY_CHANGED = 76; | ||
| EVENT_TYPE_POLICY_ENFORCEMENT_INCLUDE_TARGETS_CHANGED = 77; |
There was a problem hiding this comment.
Wondering if we should have just a "targets changed" event, and whenever/if we add "exclude targets", it's just a few more fields we add to the appropriate events.
There was a problem hiding this comment.
I like it, fixed!
Comment on lines
+998
to
+999
| // policy_id is the id of the policy that is enforced. | ||
| string policy_id = 2; |
Comment on lines
+1012
to
+1015
| // old_policy_id is the id of the old policy. | ||
| string old_policy_id = 2; | ||
| // new_policy_id is the id of the new policy. | ||
| string new_policy_id = 3; |
There was a problem hiding this comment.
Same here, missing the refs. It's possible that the change is only that:
- buf.build/acme/some-policy:foo
+ buf.build/acme/some-policy:bar
unmultimedio
approved these changes
Jul 9, 2025
doriable
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds audit log events for policy enforcements. The resource type is either server, owner (user/organization) or module. This aligns with current policy event types like
EVENT_TYPE_SERVER_UNIQUENESS_POLICY_ENABLEDthat apply to the server resource.