Fix breaking against registry for empty repositories #3896
Conversation
This fixes `buf breaking --against-registry` for newly created modlues when the default branch contains no commits. Treat the module as empty, therefore no breaking changes.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
| @@ -258,6 +261,15 @@ func run( | |||
| bufctl.WithConfigOverride(flags.AgainstConfig), | |||
| ) | |||
| if err != nil { | |||
| if connect.CodeOf(err) == connect.CodeFailedPrecondition && strings.Contains(err.Error(), "no commits in the default label") { | |||
There was a problem hiding this comment.
There must be a way to do this that is structured using ErrorDetails. Doing a string match on an error message doesn't seem right.
There was a problem hiding this comment.
Pushed a workaround for now. Will update the registry-protos to annotate the use of ErrorDetails and update the Registry to use them.
| }, | ||
| ), | ||
| ); err != nil { | ||
| if connect.CodeOf(err) == connect.CodeFailedPrecondition { |
There was a problem hiding this comment.
Why is an empty response returning failed precondition? Why not not found?
Also I would probably use list with a page size of 1, and see if the returned list has 0 elements.
There was a problem hiding this comment.
Failed precondition is due to being able to resolve the resource (a Module), but not able to return a Commit for it. The ListCommits endpoint was not used as it needs to resolve the default label, then using List would return a 404, as the default Label resource does not exist, and can't resolve.
This fixes
buf breaking --against-registryfor newly created modlues when the default branch contains no commits. Treat the module as empty, therefore no breaking changes.Related to #3641