chore: reduce info log verbosity with structured logging #2168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
changed the title
cre8ivejp
force-pushed
the
chore-info-logs
branch
from
ba5cb4d to
478b3bb
Compare
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
cre8ivejp
force-pushed
the
chore-info-logs
branch
from
478b3bb to
1ea358a
Compare
cre8ivejp
commented
Oct 27, 2025
Comment on lines
+71
to
+75
| echo '{"severity":"DEBUG","message":"'${JOB_NAME}' job completed successfully","job":"'${JOB_NAME}'","jobId":"'${JOB_ID}'","statusCode":'${RES}',"durationSeconds":'${DURATION}'}' | ||
| else | ||
| # Failure - log as ERROR with response details for debugging | ||
| BODY_ESCAPED=$(echo "${BODY}" | sed 's/\\/\\\\/g; s/"/\\"/g' | tr '\n\r\t' ' ') | ||
| echo '{"severity":"ERROR","message":"'${JOB_NAME}' job failed","job":"'${JOB_NAME}'","jobId":"'${JOB_ID}'","statusCode":'${RES}',"durationSeconds":'${DURATION}',"responseBody":"'${BODY_ESCAPED}'"}' |
There was a problem hiding this comment.
The debug logs were always reported as INFO level to GCP, so I formatted them using JSON format.
| args: | ||
| - -c | ||
| - | | ||
| echo "Start {{ .name }} job." |
There was a problem hiding this comment.
I removed the start log and implemented the elapsed time to be reported in the success log.
cre8ivejp
commented
Oct 27, 2025
Comment on lines
+26
to
+27
| app: {{ template "batch-server.name" $ }} | ||
| job-type: cronjob |
There was a problem hiding this comment.
Implemented it to report the logs as batch-server for easy tracking on the GCP console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2169