chore: change create project api to support the new console #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
cre8ivejp
commented
Oct 29, 2024
| Description: organization.Description, | ||
| IsTrial: false, | ||
| } | ||
| if err = s.createOrganization(ctx, createOrgCmd, organization, editor, localizer); err != nil { |
There was a problem hiding this comment.
We don't need to create an organization when creating a project anymore.
| req.Command.Description, | ||
| false, | ||
| editor.Email, | ||
| req.Command.OrganizationId, |
There was a problem hiding this comment.
Change it to receive the organization ID.
steveninhle
pushed a commit
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1309
I changed the CreatePrroject API to receive the organization ID when creating it instead of creating a new organization.