test: polling and retry interval behavior #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests to verify EvaluationForegroundTask scheduling logic when pollingInterval is less than, equal to, or greater than retryPollingInterval. Ensures correct request timing and retry behavior under various configurations and error conditions.
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for EvaluationForegroundTask scheduling behavior under different polling and retry interval configurations. The changes verify that the task correctly handles timing when pollingInterval is less than, equal to, or greater than retryPollingInterval, and ensures proper continuation of scheduling after both successful and failed requests.
Key Changes:
- Added test to verify scheduling continues after successful requests with retryCount at 0
- Added test for behavior when pollingInterval is shorter than retryPollingInterval (should not use retry logic)
- Added test for behavior when pollingInterval equals retryPollingInterval (should maintain consistent timing through errors and success)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../src/test/kotlin/io/bucketeer/sdk/android/internal/scheduler/EvaluationForegroundTaskTest.kt
Outdated
Show resolved
Hide resolved
Corrected spacing in the function signature of a test to improve code readability and maintain consistency with Kotlin style guidelines.
Improves readability in EvaluationForegroundTaskTest by reformatting the initialization of test configs and components to use consistent indentation and line breaks. No functional changes were made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure the Android SDK doesn’t have the same issue as described in this ticket,
this PR adds tests to verify the EvaluationForegroundTask scheduling logic when pollingInterval is less than, equal to, or greater than retryPollingInterval.
It ensures correct request timing and retry behavior under various configurations and error conditions.