Skip to content

Removed default chromium flags that delay browser launching - LOCAL #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

miguelg719
Copy link
Collaborator

why

A local browser takes a while to load due to certain flags

what changed

Disabled defaults (still optionally provided through config) to speed up local browser launching

test plan

Copy link

changeset-bot bot commented May 21, 2025

🦋 Changeset detected

Latest commit: c39317a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@miguelg719 miguelg719 marked this pull request as ready for review May 21, 2025 22:30
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Optimizes local browser launch speed by removing default Chromium flags that were causing startup delays.

  • Removed default flags --enable-webgl, --use-gl=swiftshader, --enable-accelerated-2d-canvas, and --disable-web-security from lib/index.ts
  • Kept only --disable-blink-features=AutomationControlled as default flag
  • Users can still enable removed features through localBrowserLaunchOptions.args if needed
  • May affect WebGL, canvas acceleration, and cross-origin requests unless explicitly configured

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@miguelg719 miguelg719 merged commit d312a43 into main May 22, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants