wait for dom settle with CDP network events #768
Merged
+167
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32b5df1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seanmcguire12
added
act
seanmcguire12
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR replaces browser-side mutation observers with CDP network event monitoring for DOM settling detection, addressing execution context errors during navigation.
- Implements new
_waitForSettledDominlib/StagehandPage.tsusing CDP to track network requests and determine DOM readiness - Adds intelligent handling of stalled iframe document requests with a 2-second timeout
- Introduces a 500ms "quiet window" requirement after network activity stops before considering DOM settled
- Removes
waitForDomSettlefrom browser-side code (global.d.ts,utils.ts,process.ts) - Adds
devtools-protocoldependency for CDP network event monitoring
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+467
to
+468
| const hasDoc = !!(await this.page.title().catch(() => false)); | ||
| if (!hasDoc) await this.page.waitForLoadState("domcontentloaded"); |
There was a problem hiding this comment.
logic: Check if page.title() throws for reasons other than missing document - may need more specific error handling
miguelg719
reviewed
May 24, 2025
| * If no new request appears before the timer fires, the promise | ||
| * resolves → **DOM is considered settled**. | ||
| * 7. A global guard (`timeoutMs` or `stagehand.domSettleTimeoutMs`, | ||
| * default ≈ 30 s) ensures we always resolve; if it fires we log how many |
There was a problem hiding this comment.
note: lower the default timeout
miguelg719
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
page.evaluate: Execution context was destroyed, most likely because of a navigationpage.evaluatewould throw an errorwhat changed
test plan