Caid refactor #927
Merged
Caid refactor #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklugherz
reviewed
Oct 17, 2024
| @@ -106,7 +104,10 @@ def register_alleles( | |||
|
|
|||
|
|
|||
| def build_url(base_url: str, reference_genome: ReferenceGenome) -> str: | |||
| login, password = get_ar_credentials_from_secret_manager() | |||
| login, password = ( | |||
| Env.CLINGEN_ALLELE_REGISTRY_LOGIN, | |||
There was a problem hiding this comment.
are these just going to be configured in plain text in helm?
There was a problem hiding this comment.
The LOGIN yes, the PASSWORD is going to be fetched from the kubernetes secret https://github.com/broadinstitute/seqr-helm/pull/71/files#diff-a43f3d84b733a2ff1c60f1dc01111db8fe8c957fa5c6d097b129147549977819R4. (we might put the login in the secret too just for sanity... cause that's what we're doing now?)
The idea is to initially move the secret fetch to airflow (so it'll be passed in plain text for the next few weeks 🤦 ) and then eventually it'll go away.
There was a problem hiding this comment.
The airflow side is here: https://github.com/broadinstitute/seqr-pipeline-airflow/pull/297
jklugherz
approved these changes
Oct 17, 2024
bpblanken
added a commit
that referenced
this pull request
Oct 17, 2024
bpblanken
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.