add task to write success file for run #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklugherz
commented
Oct 7, 2024
v03_pipeline/bin/pipeline_worker.py
Outdated
| project_pedigree_paths=project_pedigree_paths, | ||
| run_id=run_id, | ||
| **task_kwargs, | ||
| **loading_run_task_params, | ||
| ), | ||
| *[ | ||
| WriteProjectFamilyTablesTask( |
There was a problem hiding this comment.
there's an argument for making this a luigi task with dynamic dependencies (it would make the task parameter inheritance cleaner, and I could reuse the task inside of the WriteSuccessFileTask requires) but that feels silly since this can be accomplished by a simple loop
There was a problem hiding this comment.
👍 Do we even need WriteProjectFamilyTablesTask here if it's in the requires of the WriteSuccessFileTask?
bpblanken
reviewed
Oct 8, 2024
| ] | ||
|
|
||
| def run(self): | ||
| with hfs.open(self.output().path, mode='w') as f: |
There was a problem hiding this comment.
super nitpicky but you can just do:
with self.output().open('w') as f:
we don't need the hail filesystem for this!
bpblanken
added a commit
that referenced
this pull request
Oct 9, 2024
* add task to write success file for run (#920) * add task to write success file for run * remove WriteProjectFamilyTablesTask from pipeline_worker * no hfs * add to init * var seqr (#922) * var seqr * ruff * comma * remove luigi config in order to move it to helm --------- Co-authored-by: Julia Klugherz <juliaklugherz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.