VEP Config update #883
Merged
VEP Config update #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpblanken
commented
Aug 29, 2024
|
|
||
| def validate_vep_config_reference_genome(reference_genome) -> None: |
There was a problem hiding this comment.
No longer necessary since the reference genome is now embedded as part of the path.
hanars
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out passing
VEP_CONFIG_URIis going to be very annoying if we're trying to support both reference genomes. This fixes by:seqr-reference-datainstead ofseqr-luigiso that they're not in the "v03_pipeline" package for local users but will be downloaded with the rest of the VEP data. This pattern becomes shared between our dataproc and on prem users.