Skip to content

add stricter AF prefilter option #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

hanars
Copy link
Collaborator

@hanars hanars commented Aug 29, 2024

This expands the AF pre-filter table to include another bucket of variants, with an AF between 0.001 and 0.01. This allows us to more strictly prefilter the entries table on searches (like the AIP search) with stricter AF criteria than locus criteria

I am not sure exactly what would have to be run in order to generate this new table, let me know if I need to write anything else to assist with that

@hanars hanars requested a review from a team as a code owner August 29, 2024 16:52
@bpblanken
Copy link
Collaborator

confirming that we'll want to do this manually. Looks like our code doesn't handle the 'select' validation for these crdqs because the selects are not nested under a gnomad_genomes, which they maybe should be.

@bpblanken bpblanken merged commit d8938bc into main Sep 5, 2024
3 checks passed
@bpblanken bpblanken deleted the add-stricter-af-prefilter-option branch September 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants