Wrap import methods in validation #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into benb/wrap_import_methods_in_validation
…s into benb/wrap_import_methods_in_validation
…s into benb/wrap_import_methods_in_validation
bpblanken
changed the title
bpblanken
commented
Sep 18, 2024
| @@ -19,6 +23,29 @@ | |||
| FEMALE = 'Female' | |||
|
|
|||
|
|
|||
| def validated_hl_function( | |||
There was a problem hiding this comment.
Idea here is to wrap function with a call to "checkpoint", forcing evaluation. If one of the assigned regexes matches, we throw a validation error with the paired message.
There was a problem hiding this comment.
Additionally, I don't think any of the exceptions added in this PR can contribute to our expected "support for multiple validation errors"... any of these generally preclude further hail operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the quality of the validation errors thrown during our first import task, trying to disambiguate hail error thrown by issues with the VCF rather than Hail/Dataproc/bugs in our code.