some inheritance refactoring #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpblanken
commented
Aug 16, 2024
| @@ -12,7 +11,7 @@ | |||
|
|
|||
|
|
|||
| @luigi.util.inherits(BaseLoadingRunParams) | |||
| class WriteVariantAnnotationsVCF(BaseHailTableTask): | |||
| class WriteVariantAnnotationsVCF(luigi.Task): | |||
There was a problem hiding this comment.
we've been over-using the BaseHailTableTask to access the shared params, but this is definitely not writing or updating a hail table.
…institute/seqr-loading-pipelines into benb/some_inheritance_refactoring
bpblanken
changed the base branch from
dev
to
benb/remove_reference_data_env_var
hanars
approved these changes
Aug 19, 2024
jklugherz
approved these changes
Aug 19, 2024
bpblanken
merged commit 650f7cf
into
benb/remove_reference_data_env_var
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.