Skip to content

Split "SampleType" out from shared task base class. #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 17, 2024

Conversation

bpblanken
Copy link
Collaborator

@bpblanken bpblanken commented Jun 12, 2024

This is a part 1 of a broader refactor to greatly simplify the parameter passing from airflow. SampleType doesn't belong on the "Delete" tasks anyways.

@bpblanken bpblanken changed the base branch from dev to benb/crdqs_no_private June 12, 2024 17:13
Base automatically changed from benb/crdqs_no_private to dev June 13, 2024 14:08
@bpblanken bpblanken changed the title Benb/split out sample type Split "SampleType" out from shared tasks. Jun 17, 2024
@bpblanken bpblanken changed the title Split "SampleType" out from shared tasks. Split "SampleType" out from shared task base class. Jun 17, 2024
@bpblanken bpblanken marked this pull request as ready for review June 17, 2024 15:09
@bpblanken bpblanken requested a review from a team as a code owner June 17, 2024 15:09
@bpblanken bpblanken merged commit 97b90a6 into dev Jun 17, 2024
3 checks passed
@bpblanken bpblanken deleted the benb/split_out_sample_type branch June 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants