Benb/add key to pipeline #1086
Merged
Benb/add key to pipeline #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpblanken
commented
Apr 22, 2025
| # Add serial integer index | ||
| new_variants_ht = new_variants_ht.add_index(name='key_') | ||
| new_variants_ht = new_variants_ht.transmute( | ||
| key_=new_variants_ht.key_ + annotations_ht.index_globals().max_key_ + 1, |
There was a problem hiding this comment.
Idea here is to use a serially increasing counter to ensure that the assigned keys are always new. Though we might not support deleting variants in the future, we currently do have flows that will result in variants being removed!
hanars
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/broadinstitute/seqr-private/issues/1633