CORE-609: update last step of nightly automation test to reflect CRDC offboarding #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Aug 18, 2025
| "ENV": "${{ matrix.testing-env }}", | ||
| "test-context": "${{ needs.prepare-configs.outputs.test-context }}", | ||
| "ref": "${{ needs.prepare-configs.outputs.tag }}" | ||
| "ref": "${{ inputs.test-code-ref || needs.prepare-configs.outputs.tag }}" |
There was a problem hiding this comment.
this allows specifying which branch of test code to run, instead of always using the latest tag.
davidangb
requested review from
calypsomatic,
kevinmarete and
samanehsan
and removed request for
a team
kevinmarete
approved these changes
Aug 18, 2025
samanehsan
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1658, which was only a partial fix.
Since we no longer sync TARGET and TCGA dataset permissions, we can't use those datasets in the nightly test. This updates the test to use other datasets.
As a bonus, this PR also includes a fix to allow kicking off test runs using an arbitrary branch of test code.
I kicked off a test run using this code and it passed; see https://github.com/broadinstitute/firecloud-orchestration/actions/runs/17043664395/job/48314904895.