CORE-382: delete Data Library #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Apr 10, 2025
| baseOntologyUrl = "https://consent-ontology.dsde-dev.broadinstitute.org" | ||
| dulvn = 4 | ||
| } | ||
|
|
There was a problem hiding this comment.
Once this PR is deployed to prod, I'll follow up with another PR to remove these config stanzas from terra-helmfile.
davidangb
commented
Apr 10, 2025
| val akkaHttpV = "10.6.3" | ||
| val jacksonV = "2.18.3" | ||
| val jacksonHotfixV = "2.18.3" // for when only some of the Jackson libs have hotfix releases | ||
| val nettyV = "4.1.119.Final" |
There was a problem hiding this comment.
all of the libraries removed in this PR are no longer needed, given all the code deletion.
davidangb
commented
Apr 10, 2025
| } | ||
|
|
||
| private def patchAndRepublishWorkspace(workspaceNamespace: String, | ||
| private def patchWorkspaceTags(workspaceNamespace: String, |
There was a problem hiding this comment.
I renamed this method since "publishing" is no longer a thing
davidangb
commented
Apr 10, 2025
| } ~ | ||
| path("acl") { | ||
| patch { | ||
| // TODO CORE-382: can this be a passthrough? |
There was a problem hiding this comment.
this isn't related to Data Library so I'm leaving it out of this PR; I'll look to create a separate PR for this
davidangb
requested review from
marctalbott and
samanehsan
and removed request for
a team
samanehsan
approved these changes
Apr 14, 2025
davidangb
requested review from
calypsomatic and
dvoet
and removed request for
a team
calypsomatic
approved these changes
Apr 15, 2025
dvoet
approved these changes
Apr 15, 2025
davidangb
added a commit
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-382
/api/libraryAPIs/duosAPIs/api/workspaces/{namespace}/{name}/catalogAPIsWith all this change, there are some Rawls, terra-helmfile, and probably Sam cleanup to do. I'll take care of that followup work as part of the same Jira ticket.