Skip to content

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Dec 16, 2024

Removes all calls to passthrough and replaces them with more generic streamingPassthrough calls. Removes the passthrough directive itself.

✅ passed unit tests

✅ passed swat tests

✅ manually tested while running locally:

  1. used swagger-ui to check most of the APIs affected by this PR

✅ manually tested in a BEE:

  1. create and share billing project
  2. create workspace
  3. import WDL from Dockstore to workspace
  4. launch and complete a Cromwell submission

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge. Make sure your branch deletes; GitHub should do this for you.
  • Test this change deployed correctly and works on dev environment after deployment

@davidangb davidangb marked this pull request as ready for review December 16, 2024 21:48
@davidangb davidangb requested a review from a team as a code owner December 16, 2024 21:48
@davidangb davidangb requested review from kevinpalis and marctalbott and removed request for a team December 16, 2024 21:48
@davidangb davidangb merged commit b081de4 into develop Dec 17, 2024
13 checks passed
@davidangb davidangb deleted the da_CORE-165_evenMorePassthroughs branch December 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants