Skip to content

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Dec 6, 2024

draft, do not review

  • when parsing a TSV upload, if a value is quoted, remove the quotes and always treat that value as a string.
  • when downloading a TSV, if an existing string value looks like a number or a boolean, quote that value. This is necessary so that if the TSV is re-uploaded, Orch will still recognize the value as a string.

This feature adds significant overhead to TSV uploads and downloads.

In rather informal testing on my local machine, I ran this large-TSV download unit test in a tight loop and measured the timing.

This PR: average 44.59 seconds, N=60
develop branch: average 2.51 seconds, N=40


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge. Make sure your branch deletes; GitHub should do this for you.
  • Test this change deployed correctly and works on dev environment after deployment

@davidangb davidangb closed this Jun 12, 2025
@davidangb davidangb deleted the da_CORE-207_tsvsAndQuotes branch June 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant