CORE-131 Get emails from sam instead of thurloe #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
requested review from
a team,
samanehsan and
trholdridge
and removed request for
a team
dvoet
commented
Oct 31, 2024
Comment on lines
-291
to
-296
| assertSameElements(Set(services.thurloeDao.TCGA_AND_TARGET_LINKED, services.thurloeDao.TCGA_LINKED), | ||
| services.samDao.groups(tcgaDbGaPAuthorized).map(_.value) | ||
| ) | ||
| assertSameElements(Set(services.thurloeDao.TCGA_AND_TARGET_LINKED, services.thurloeDao.TARGET_LINKED), | ||
| services.samDao.groups(targetDbGaPAuthorized).map(_.value) | ||
| ) |
There was a problem hiding this comment.
I removed these checks and the on below because they only test that we have our mocks setup correctly which is not useful. The underlying function is well tested in unit tests.
trholdridge
approved these changes
Oct 31, 2024
samanehsan
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/CORE-131
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: