Skip to content

CORE-126: scalafmt enforcement #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

CORE-126: scalafmt enforcement #1467

merged 4 commits into from
Oct 25, 2024
+39 −1

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Oct 25, 2024 •
edited
Loading

Followup to #1468.

That other PR performed a mass reformat of code to meet scalafmt standards.

This PR adds:

  • scalafmt configuration in Settings.scala to optimize formatting performance
  • a format check in github actions for PRs
  • introduction of .git-blame-ignore-revs, so the mass reformat doesn't show up in git blames

@davidangb davidangb mentioned this pull request Oct 25, 2024
Merged
@davidangb davidangb changed the title scalafmt enforcement CORE-126: scalafmt enforcement Oct 25, 2024
@davidangb davidangb marked this pull request as ready for review October 25, 2024 18:32
@davidangb davidangb requested review from a team, calypsomatic, dvoet, kevinmarete and marctalbott and removed request for a team, dvoet and marctalbott October 25, 2024 18:34
@davidangb davidangb merged commit 1646e20 into develop Oct 25, 2024
13 checks passed
@davidangb davidangb deleted the da_scalafmt branch October 25, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calypsomatic calypsomatic calypsomatic approved these changes

@kevinmarete kevinmarete kevinmarete approved these changes

+1 more reviewer

@dvoet dvoet dvoet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidangb @dvoet @calypsomatic @kevinmarete