-
Notifications
You must be signed in to change notification settings - Fork 2
[DSEC-963] add retry loop #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - retry for dojo connections and for zap shutdown.
I notice you also increased a Hail timeout - perhaps add a comment about that in the PR conversation (if not split to a separate PR).
Several small pipeline changes to try and improve reliability.
A new retry loop around creating an engagement in defect dojo. Several scans were consistently failing on this step, and hopefully this helps to alleviate this issue.
Broke out the zap shutdown action, and tried to fix the intermittent timeout issue.
The TIMEOUT_MINS value was increased by one. This value is used for communicating with the local instance of ZAP. There had been an increase in timeouts when connecting with ZAP from the zap-scans controller, and this is an attempt to reduce those timeouts.
The requestspersecond value was decreased by 1. This is across all scans as an attempt to reduce issues where the scanner was encountering 502 or 503 errors while scanning.