Update to Rust v1.88 #267
Merged
Update to Rust v1.88 #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewlacy
commented
Jun 29, 2025
| let mut download_stream = response | ||
| let download_stream = response |
There was a problem hiding this comment.
download_stream gets wrapped with std::pin::pin!(). In Rust v1.88, this started triggering an unused_mut warning.
I couldn't find anything in the release notes that would explain why this is now a warning, but I'm guessing it's probably a result of this change: rust-lang/rust#139114
This was referenced Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Rust version in
rust-toolchain.toml,Cargo.toml, andproject.brito use Rust v1.88.0.There was a new warning that appeared that I fixed. I also made a few miscellaneous tweaks to the Brioche-in-Brioche build:
sqlx-clibuild with upstreamsqlx_clipackage (feat(sqlx_cli): add package brioche-packages#719)