Skip to content

Conversation

ohookins
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #7327

Please read the issue for more details. I don't think this is a very good fix, and it should probably be handled within the runner registry rather than outside (especially since there are numerous other mechanisms involving runners and the registry). But it shows what is going on at least - some state persisted in the runners and runner registry overwrites the scan configuration for the second and subsequent directories, and no additional scans are performed.

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

This is a band-aid fix at the moment, to show the issue. It just creates a new runner registry for every directory to be scanned, and accumulates the scan report results to be processed at the end of the run.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Providing multiple directories only checks the first one (multiple times)

1 participant