fix(terraform_plan): Don't add values to empty list values in after_unknown #7319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing after_unknown
lirshindalman
approved these changes
Oct 5, 2025
maxamel
reviewed
Oct 8, 2025
checkov/terraform/plan_parser.py
Outdated
| resource_conf[k][0][inner_key] = _clean_simple_type_list([TRUE_AFTER_UNKNOWN]) | ||
| elif isinstance(resource_conf[k][0], list) and isinstance(resource_conf[k][0][0], dict): | ||
| resource_conf[k][0][0][inner_key] = _clean_simple_type_list([TRUE_AFTER_UNKNOWN]) | ||
| if _validate_after_unknown_list_not_empty(inner_key, k, resource_conf): |
There was a problem hiding this comment.
Should we really invoke the same condition in both cases?
I would expect the second condition to be invoked with k[0], since the second one is operating at a deeper level.
maxamel
reviewed
Oct 8, 2025
| } | ||
| ]} | ||
| key: str = 'network_configuration' | ||
| value: list = [ |
There was a problem hiding this comment.
Can we have more than one item in this list?
There was a problem hiding this comment.
updated the function to handle case where there are more than 1 by going in for loop
maxamel
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes a bug in which empty lists in after_unknown section were inserted a new value, now the value stays an empty list.
Checklist: