Skip to content

feat(terraform): fix foreach module handling #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2025
Merged

feat(terraform): fix foreach module handling #7313

merged 3 commits into from
Sep 28, 2025

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Sep 28, 2025 •
edited
Loading

This PR fixes handling of for_each modules where only the first instance used to be populated with the updated for_each attributes. Now we iterate over the entire list.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@maxamel maxamel changed the title fix foreach module handling feat(terraform) - fix foreach module handling Sep 28, 2025
@maxamel maxamel changed the title feat(terraform) - fix foreach module handling feat(terraform): fix foreach module handling Sep 28, 2025
@maxamel maxamel marked this pull request as ready for review September 28, 2025 11:20
@maxamel maxamel merged commit dbf0d2a into main Sep 28, 2025
47 of 48 checks passed
@maxamel maxamel deleted the fix-foreach-module-update branch September 28, 2025 12:40
Saarett pushed a commit that referenced this pull request Sep 28, 2025
@maxamel @actions-user
feat(terraform): fix foreach module handling (#7313)
c3fc6f8 
* fix foreach module handling

* add tests for foreach module handling

* replace test check to more uncommon check

---------

Co-authored-by: Max Amelchenko <mamelchenko@paloaltonetworks.com>
@marceldevroed marceldevroed mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bo156 bo156 bo156 approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxamel @bo156 @ChanochShayner